Repository navigation
test(sandbox): isolate Landlock descriptor-limit regression - #4457
Conversation
Signed-off-by: Gordon Sim <gsim@redhat.com>
|
/ok to test c6c5e39 |
|
Label |
johntmyers
left a comment
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The isolated descriptor-limit regression test matches #4455 and exercises the production Landlock baseline preparation path. The independent code review found no blocking issues.
Test dispatch is temporarily blocked: the E2E Label Help bot requested Re-run all jobs, but GitHub refuses to rerun the current attempt while it remains active. I requested cancellation; the supervisor will retry the authorized rerun after this attempt finishes. Some build jobs show failures, but their logs are currently inaccessible from this sandbox, so their cause is not yet established.
Action required: Gator should confirm cancellation/completion, rerun the current-head E2E workflow, and verify a new attempt before advancing to pipeline monitoring. No author code change is requested by this review.
Blocking findings: None.
Carried findings: None.
Non-blocking suggestions: None.
Gator metadata
- Validation: Focused test correction with reproduction and acceptance criteria in #4455; no duplicate implementation identified.
- Docs: Not needed; only a regression test changes, with no user-facing behavior change.
- Checks: DCO, vouch, Helm Lint, and Trivy Changes pass; Branch Checks are running.
- E2E:
test:e2eapplied;/ok to testposted with the freshly read full current head; mirror is current. E2E rerun is awaiting completion of attempt 1 after a cancellation request. - Head SHA:
c6c5e397b4c3a2d2c76b490c40631a69dc68f4f8 - Base SHA:
5e414eadde83644d7a8a27554313b74a8bd61639 - Merge base SHA:
ca187123dd807f5e0f1cbeae64dcbf32245c296f - Patch ID:
8bb288437833d184a4b2f17842d3f92a62176441 - Gator payload:
12 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:blocked - Blocked reason:
test_dispatch_required
johntmyers
added
gator:blocked
johntmyers
removed
the
gator:approval-needed
Monitoring CompleteMonitoring is complete because this PR has merged. The independent review found no blocking issues, all required checks including E2E passed, and @johntmyers approved the current head. I removed the active Gator metadata
|
2 participants
Summary
Fix an intermittent Landlock regression test failure caused by counting descriptors shared with concurrently running tests. Verify actual baseline preparation in an isolated subprocess under a low descriptor limit.
Related Issue
Closes #4455
Changes
Testing
Checklist